numaflow icon indicating copy to clipboard operation
numaflow copied to clipboard

containerTemplate gets propagated to initContainer in spec

Open kohlisid opened this issue 6 months ago • 1 comments

Describe the bug While applying an containerTemplate to a vertex, it gets partially propagated to the initContainer spec as well causing a mismatch in spec and issues in reconciler.

To Reproduce Steps to reproduce the behavior:

Used this spec

vertices:
- name: in
  scale:
    min: 1
  # A self data generating source
  source:
    generator:
      rpu: 50
      duration: 1s
      # 1Mb
      msgSize: 1000000
  initContainerTemplate:
    resources:
      limits:
        cpu: "4"
        memory: 1Gi
      requests:
        cpu: "4"
        memory: 1Gi
  containerTemplate:
    resources:
      limits:
        cpu: "4"
        memory: 8Gi
      requests:
        cpu: "4"
        memory: 8Gi

Expected behavior Container template should only be applied to the numa container only.

Screenshots

skohli@macos-JQWR9T560R manifests % kubectl get vtx
NAME                  PHASE    REASON            MESSAGE                                                                                                                                                            DESIRED   CURRENT
simple-pipeline-in    Failed   CreatePodFailed   Pod "simple-pipeline-in-0-4nmul" is invalid: spec.initContainers[0].resources.requests: Invalid value: "8Gi": must be less than or equal to memory limit of 1Gi    1         0
simple-pipeline-out   Failed   CreatePodFailed   Pod "simple-pipeline-out-0-yg7w1" is invalid: spec.initContainers[0].resources.requests: Invalid value: "8Gi": must be less than or equal to memory limit of 1Gi   1         0

Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

For quick help and support, join our slack channel.

kohlisid avatar Aug 07 '24 02:08 kohlisid