react-native-compressor icon indicating copy to clipboard operation
react-native-compressor copied to clipboard

Error[TypeError: VideoCompressEventEmitter.removeSubscription is not a function. (In 'VideoCompressEventEmitter.removeSubscription(subscription)', 'VideoCompressEventEmitter.removeSubscription' is undefined)]

Open valn1 opened this issue 2 years ago • 2 comments

Current behavior

throws error on 99% and does not finish the compression when there is the 'onProgress' option

Expected behavior

finish the compression and get to 100%

Platform

  • [X] Android
  • [] iOS(not tested yet)

React Native Version

0.65.1

React Native Compressor Version

0.5.17

Reproducible Steps And Demo

...

valn1 avatar Apr 28 '22 20:04 valn1

👋 @valn1 Thanks for opening your issue here! If you find this package useful hit the star🌟!

github-actions[bot] avatar Apr 28 '22 20:04 github-actions[bot]

Hello, for what i know, this problem can be solved simply by changing

VideoCompressEventEmitter.removeSubscription(subscription);

by

subscription.remove()

as the method removeSubscription has been removed in https://github.com/facebook/react-native/commit/d39643b9de11c6b44984166ede34a7f44de76fe5#diff-9f250e6d8a5ec553d894b660a762e5975e048fcb822ece9d1af7a72d93b3cb71

valn1 avatar May 02 '22 14:05 valn1

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 03 '23 01:05 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar May 11 '23 01:05 github-actions[bot]