num0005
Hide extract tags tab for Reach+. Show FMOD Repair tab for Reach
Simple changes to help avoid user confusion:
- Only show "Extract Tags" tab when profile is H2/H3/ODST. Previously was shown for Reach and H4/2AMP as well - incorrectly reporting success despite those tags not having source info
- Allow "FMOD Repair" tab to show when selected profile is Reach, in addition to H3/ODST. Have tested with Reach and the fix process is identical so no code change is required
I also think that whether we actually hide or just "disable" a given tab when it is not used by a profile should be made more consistent. For example "Import Model" and "Import Sound" tabs are just greyed out for H4/2AMP as they can't be used, but the "Extract Tags" tab isn't just disabled for CE, but hidden entirely
I feel like there was a reason it was greyed out vs hidden. I think it had to do with the buttons being in the middle and causing weirdness with the UI. I assume you already made sure that's all good tho.
I feel like there was a reason it was greyed out vs hidden. I think it had to do with the buttons being in the middle and causing weirdness with the UI. I assume you already made sure that's all good tho.
Fair enough, I've done some playing around and can't see any issues arising from just hiding the tabs instead of disabling. Might be that when I made the spacing for the tabs consistent a while back it fixed any issues with the tabs becoming misaligned depending on how many are visible? Regardless, with this commit I've settled with consistently hiding unusable tabs for a given engine rather than greying out, as I feel that's probably the option that confuses the user the least. Having extra disabled tabs showing that can never be enabled/used just seems a bit odd to me ig
Pretty sure I've checked all possible engine types for any issues but please give a scroll through them to make sure I didn't miss any
Examples:
H4 Before
H4 After
H3 vs Reach - Extract Tags and Import Sidecar tabs seamlessly switch