squid icon indicating copy to clipboard operation
squid copied to clipboard

Add support for Ruby 3.0

Open floriandejonckheere opened this issue 5 years ago • 3 comments

Ruby 3.0 separates positional from keyword arguments, which renders some calls in the gem not to work anymore (mostly where options is used as a Hash instead of keyword arguments). Splatting the hash makes the methods work again.

floriandejonckheere avatar Jan 08 '21 07:01 floriandejonckheere

Coverage Status

Coverage remained the same at 100.0% when pulling 0e67fbebe2012c82a64f9716c18cfe8025173630 on floriandejonckheere:ruby-3-0-0 into 08eae1d881a8324cee50d7e6bd2c6ca76779bd13 on Fullscreen:master.

coveralls avatar Jan 08 '21 07:01 coveralls

👍 @Fullscreen Is there any chance that you might be able to merge this? Squid doesn't work with Ruby 3.x without it.

timrogers avatar Oct 28 '21 10:10 timrogers

Thanks @floriandejonckheere, I was able to get going again by updating my gemfile to point at your branch:

gem "squid", "~> 1.4", github: "floriandejonckheere/squid", ref: "0e67fbebe2012c82a64f9716c18cfe8025173630"

rmosolgo avatar Jan 28 '22 20:01 rmosolgo

Fixed in #68

justinhoward avatar Apr 03 '23 15:04 justinhoward