bh icon indicating copy to clipboard operation
bh copied to clipboard

Support for btn input addons

Open buren opened this issue 10 years ago • 6 comments

Adds support for http://getbootstrap.com/components/#input-groups-buttons

buren avatar Sep 14 '14 14:09 buren

Coverage Status

Coverage remained the same when pulling 1094c07f15e8d021e0f4216477e290c2739bfecb on buren:input-button-addons into d40656c943b3d5e77f445afe176028439273890e on Fullscreen:master.

coveralls avatar Sep 14 '14 14:09 coveralls

Looking at the code, I realize that we might actually want a simple button helper that does not mess up with button_to.

<%= button 'Go', context: :success %>

would simply transform into

<button class="btn btn-success" type="button">Go</button>

Initially I thought we could just use button_to in every occasion, but I realize there might be cases where users simply want buttons not tied to a form.

Once the button helper is merged, then the PR above becomes much easier.

claudiofullscreen avatar Sep 15 '14 18:09 claudiofullscreen

Also, ActionView already provides a similar helper called button_tag, so might look into that as well.

claudiofullscreen avatar Sep 15 '14 18:09 claudiofullscreen

That is the exact thing I've done in #15 in button_group_helper :) On 15 Sep 2014 20:34, "claudiofullscreen" [email protected] wrote:

Looking at the code, I realize that we might actually want a simple button helper that does not mess up with button_to.

<%= button 'Go', context: :success %>

would simply transform into

Initially I thought we could just use button_to in every occasion, but I realize there might be cases where users simply want buttons not tied to a form.

Once the button helper is merged, then the PR above becomes much easier.

— Reply to this email directly or view it on GitHub https://github.com/Fullscreen/bh/pull/25#issuecomment-55635958.

buren avatar Sep 15 '14 18:09 buren

Yes! Taking a look at that now.

claudiofullscreen avatar Sep 15 '14 18:09 claudiofullscreen

@claudiofullscreen status? let me know if I can do anything

buren avatar Sep 26 '14 14:09 buren