bh icon indicating copy to clipboard operation
bh copied to clipboard

alert: add alert-dismissible class

Open mattscilipoti opened this issue 8 years ago • 5 comments

Per https://getbootstrap.com/components/#alerts-dismissible, dismissible alert boxes should have an alert-dismissable css class.

mattscilipoti avatar Nov 22 '16 21:11 mattscilipoti

Coverage Status

Coverage remained the same at 100.0% when pulling 150b8c771fb236b13a8a5a7161fe4eb61ff6121b on mattscilipoti:alert_dismissible into 88a6398cf62081eea25a36f22ad79801780da4e3 on Fullscreen:master.

coveralls avatar Nov 22 '16 21:11 coveralls

@mattscilipoti Is this what you are looking for?

http://fullscreen.github.io/bh/#dismissible-alerts

claudiofullscreen avatar Nov 22 '16 21:11 claudiofullscreen

@claudiofullscreen Yes. That element is just missing the 'alert-dismissible' class, that bootstrap specifies should be there. My pull request simply adds that class. Bootstrap has some styling for that class.

mattscilipoti avatar Nov 22 '16 21:11 mattscilipoti

The broken travis build is having an issue installing json. I don't think this small change is related to that issue.

mattscilipoti avatar Nov 22 '16 21:11 mattscilipoti

Here is the listed failure from travis-ci. It is not related to the changes in this PR. I expect it is affecting other PRs too. I don't know how you are managing multiple rubies, but it looks like something isn't configured correctly.:

...
Gem::InstallError: json requires Ruby version ~> 2.0.
Installing tilt 1.4.1
An error occurred while installing json (2.0.2), and Bundler cannot continue.
Make sure that `gem install json -v '2.0.2'` succeeds before bundling.
The command "eval bundle install --jobs=3 --retry=3" failed. Retrying, 2 of 3.
...

Please review.

mattscilipoti avatar Jan 26 '17 22:01 mattscilipoti