bh icon indicating copy to clipboard operation
bh copied to clipboard

Published 20 hours ago • verified publisher icon nullscreen

Avoid marking a string as .html_safe unless you are sure

Open mintuhouse opened this issue 8 years ago • 2 comments

i.e., only for cases where string is constant

  • Also fixes a subtle bug involving safe_join([helper_object]), where helper_object.html_safe? may not be defined or may not return true but helper_object.to_s.html_safe? returns true e.g., https://github.com/Angelmmiguel/material_icons bh escapes the html instead of displaying icon today

mintuhouse avatar Mar 31 '16 15:03 mintuhouse

Coverage Status

Coverage remained the same at 100.0% when pulling 792ffa9d7f873739f91ba51671352ce0c881df24 on mintuhouse:improve_safe_join into 88a6398cf62081eea25a36f22ad79801780da4e3 on Fullscreen:master.

coveralls avatar Mar 31 '16 15:03 coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling 839614a8603e983c9c0707edf64881ce06c5f3e2 on mintuhouse:improve_safe_join into 88a6398cf62081eea25a36f22ad79801780da4e3 on Fullscreen:master.

coveralls avatar Apr 04 '16 13:04 coveralls