bh icon indicating copy to clipboard operation
bh copied to clipboard

Respect attribute translations in #check_box

Open atipugin opened this issue 9 years ago • 9 comments

Solves this issue: https://github.com/Fullscreen/bh/issues/123

atipugin avatar Mar 12 '15 12:03 atipugin

Coverage Status

Coverage decreased (-29.74%) to 70.26% when pulling 66303f1da1e0b31e7db9f22f113415f9e766b653 on atipugin:master into 98e0743cf606d78a391bf35027b38387ab26d15c on Fullscreen:master.

coveralls avatar Mar 12 '15 12:03 coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling 2dfd42a1956311142593a3899c1cb77aba1ade2e on atipugin:master into 98e0743cf606d78a391bf35027b38387ab26d15c on Fullscreen:master.

coveralls avatar Mar 12 '15 12:03 coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling 14969fecdb07eca372cf74b7b3714f796e193520 on atipugin:master into 98e0743cf606d78a391bf35027b38387ab26d15c on Fullscreen:master.

coveralls avatar Mar 12 '15 12:03 coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling 7ed85326bdb6eb0532cf3ee0e5e21691856cdef9 on atipugin:master into 98e0743cf606d78a391bf35027b38387ab26d15c on Fullscreen:master.

coveralls avatar Mar 12 '15 14:03 coveralls

Could you also squish all your commits together? Thanks! :ribbon:

claudiofullscreen avatar Mar 12 '15 15:03 claudiofullscreen

Changed code to if/else statement. Answering your questions:

  1. "#default" is too ambiguous for this. Module itself handles whole checkbox, not only a label's text.
  2. Code will work. #human_attribute_names uses same #humanize as fallback for absent translations.

atipugin avatar Mar 12 '15 15:03 atipugin

Coverage Status

Coverage decreased (-0.05%) to 99.95% when pulling b758a6a574b68e7e858d6975b2ec2c235f7baba0 on atipugin:master into 98e0743cf606d78a391bf35027b38387ab26d15c on Fullscreen:master.

coveralls avatar Mar 12 '15 15:03 coveralls

Coverage Status

Coverage decreased (-0.05%) to 99.95% when pulling f10011d78fc9d5593c088c0e025b0f34004a11c4 on atipugin:master into 98e0743cf606d78a391bf35027b38387ab26d15c on Fullscreen:master.

coveralls avatar Mar 12 '15 15:03 coveralls

Ping! :star2:

koenpunt avatar Jan 12 '16 16:01 koenpunt