PCExhumed: demo.vcr desync

[BSzili]

I noticed that in the on the demo playback now desyncs in PCExhumed. In the underwater section the second fish goes up too high after the first machete hit, so the player can't kill it, can't pick up the Power key, and gets stuck underwater. I traced this back, and the behavioral change was introduced somewhere in commit a7dcae9a7. r11735 was the latest build where the demo played back, r11736 desyncs.

[sirlemonhead]

Thanks for letting me know! - I seem to be always breaking things :D I had actually figured sync was broken when we started checking for sqrt() overflows but I probably broke something in the fish AI when I was reshuffling things.

Will take a look as soon as possible :)

[BSzili]

Thank you so much for looking into this! I also noticed that the demos saved by PCExhumed can't be played back in either version (PCEx, DOS). I think this is caused by the size difference of the GameStat struct that embeds the extended Player struct. This is also makes SAVGAMEA.SAV incompatible with the DOS version and vice versa, so maybe GameStat could be replaced with the demo_header struct.

[sirlemonhead]

Thanks! Have the demo sync issue fixed now (hopefully!) and will look at the backwards compatibility with DOS next.