react-ui-cards icon indicating copy to clipboard operation
react-ui-cards copied to clipboard
verified publisher icon nukeop

Add localization to 'Buy now' button as prop

Open mangione77 opened this issue 6 years ago • 3 comments

Hello,

Thanks for your great work, it's been really useful.

Would it be a possibility to extend the functionality of the ProductCard, so it accepts the text to display in the 'Buy now' button as prop? Right now I'm editing the source code in the bundle and it's not that easy as passing a prop.

Thanks again for the awesome work!

mangione77 avatar Jun 10 '19 20:06 mangione77

Thank you for your kind words. Would you like to submit a PR, or would you rather have me do it instead? I can do it tomorrow and update the package then.

nukeop avatar Jun 10 '19 21:06 nukeop

Thank you for the quick response. I think it would be quicker/easier if you add the prop. I can submit a PR if you wish, but it would take a couple of days.

Thanks!

mangione77 avatar Jun 11 '19 06:06 mangione77

Ok, I added a new buttonText prop for that card and published the new version on npm. Update to 1.5.2 and let me know if that fixes your problem.

nukeop avatar Jun 12 '19 22:06 nukeop