nuclear icon indicating copy to clipboard operation
nuclear copied to clipboard

Translations (looking for contributors)

Open nukeop opened this issue 6 years ago • 89 comments

We're looking for contributors who are willing to translate Nuclear to their native languages (or any languages that they know well). Currently @charjac has done all the work required to add new translations, and also translated all the strings to French.

Suggest translations here: https://crowdin.com/project/nuclear

Guidelines can be found here: https://nukeop.gitbook.io/nuclear/contributing/translating

nukeop avatar Jun 05 '19 21:06 nukeop

When adding translations, a few things need to be done:

  • add the json file with the correct name in app/locales and keep it empty
  • update the i18n script in package.json by adding your locale
{
  ...
  "scripts": {
    ...
     "i18n": "sync-i18n --files 'app/locales/*.json' --primary en --languages fr [your locale] --space 2"
  } 
  ...
}
  • run the command
npm run i18n
  • edit the file common/settings.js to add your local in user's choice
  {
    name: 'language',
    category: 'program-settings',
    type: settingType.LIST,
    prettyName: 'language',
    placeholder: 'language-placeholder',
    options: ['en', 'fr', <your locale>],
    default: undefined
  }
  • edit the app/i18n.js file
...
import en from './locales/en.json';
import <your locale> from './locales/<your locale>.json';
...
    resources: {
      en,
      ...
      <your locale>
    },
...

you can now translate your locale file from english to your language.

After you're done, you can add your translation to the readme, under "Community translations".

c-jacquin avatar Jun 06 '19 08:06 c-jacquin

Hey @nukeop, I would like to help you translate Nuclear from English to Danish if this has any interest?

Hansen1992 avatar Jun 10 '19 14:06 Hansen1992

Absolutely, in general if you don't see a language on the list above, we want it added. Thanks for the help.

nukeop avatar Jun 10 '19 21:06 nukeop

What kind of things or phrases would you like to be translated? I'm a native English speaker but I took a few years of Chinese (Mandarin, so I write simplified). I may not be able to do much, but I would be happy to start and do as much as I can.

lizzyd710 avatar Jun 11 '19 15:06 lizzyd710

You can see a list of all strings that have to be translated here: https://github.com/nukeop/nuclear/blob/master/app/locales/en.json

Even if you only translate a part of it, any missing strings fall back on default English. And some is better than nothing.

nukeop avatar Jun 11 '19 17:06 nukeop

(This might not be the appropriate place for this, so I apologize and let me know if/where you want me to move this.) Do I need to run npm run i18n before editing app/constants/settings.js and app/i18n.js? I'm having some issues with setting up the NPM dev environment for working on this repo, and I'm wondering if I could just edit the files in the meantime to try and get started on the translations while I troubleshoot.

lizzyd710 avatar Jun 12 '19 13:06 lizzyd710

npm run i18n just fill the new json file with english translation. you can copy paste en.json content to (your locale).json, it will do the same.

wich error do you get when you setup dev environment ?

c-jacquin avatar Jun 12 '19 17:06 c-jacquin

(If I should have posted this in pastebin or something else, let me know. I know different repos have different protocols for this type of thing.) image

lizzyd710 avatar Jun 13 '19 13:06 lizzyd710

arf windows :'( :'(

There is a few things you can try:

  • run your cmd as administrator
  • delete node_modules and then run npm install
  • maybe try gitbash ?
  • help !!! :)

c-jacquin avatar Jun 13 '19 13:06 c-jacquin

I think it's a matter of running npm install first.

nukeop avatar Jun 13 '19 13:06 nukeop

Yeah, I reinstalled and it loaded, it's just stuck on the nuclear logo screen. Would I be able to run the i18n command though, or do I need to figure out why the app isn't loading first? (Again, sorry for clogging up this issue. Is there a better place for me to go for this, or is here fine?)

lizzyd710 avatar Jun 13 '19 18:06 lizzyd710

So, I was afraid this would be an issue with translating to Chinese, but even when I save the zh.json file with Unicode encoding it doesn't properly parse...how should I go about trying to handle this?

lizzyd710 avatar Jun 13 '19 18:06 lizzyd710

Talking about it here is fine. Could you start a pull request with the changes you've made so far so I can pull them and check? Maybe it'll work fine for me, and even if it doesn't I'll be in a better position to judge what's wrong.

nukeop avatar Jun 13 '19 20:06 nukeop

Hey there! I would like to translate it to Russian! Let me know what you think!

ramstore07 avatar Jun 14 '19 03:06 ramstore07

Sure, this is a great idea. Let me know if there are any problems.

nukeop avatar Jun 14 '19 07:06 nukeop

Talking about it here is fine. Could you start a pull request with the changes you've made so far so I can pull them and check? Maybe it'll work fine for me, and even if it doesn't I'll be in a better position to judge what's wrong.

I think I figured it out. I saved it with Unicode encoding but I should have saved it as UTF-8. sigh

Now I just have to figure out how to actually get the program to get past the logo and I can test and submit a pull request.

lizzyd710 avatar Jun 15 '19 18:06 lizzyd710

This is coming along really, really well. We've got 9 languages already, and it's barely been two weeks.

nukeop avatar Jun 21 '19 23:06 nukeop

Hi there! Though it's my first time to contribute to a GitHub project, I would like to translate it into Chinese(Traditional). Can I give it a try?

ghost avatar Jul 02 '19 11:07 ghost

Absolutely, everyone is welcome to contribute.

nukeop avatar Jul 02 '19 11:07 nukeop

Hi :) I'll start to translate it to hebrew

avirec avatar Jul 11 '19 08:07 avirec

Thank you. Let me know if it causes any problems, I don't know if RTL languages will be rendered correctly.

nukeop avatar Jul 11 '19 08:07 nukeop

Just to make sure (and sorry for the newbie question) - should I open a branch and work on the relevant files locally, and when I finish - to do a pull request?

avirec avatar Jul 11 '19 10:07 avirec

First you need to fork the repository using the button in the top right corner. This creates your own copy. Inside that copy, you can either create a new branch, or work on the master branch (up to your preference). After you're finished, you'll have the option to create a new pull request from the branch you worked on to my repo.

nukeop avatar Jul 11 '19 11:07 nukeop

Thank you. Let me know if it causes any problems, I don't know if RTL languages will be rendered correctly.

Is there a way to check the RTL before I'll complete the translation?

avirec avatar Jul 11 '19 18:07 avirec

You can try starting the development version and selecting your new language in the settings.

$ npm install
$ npm run watch && npm run electron:dev

nukeop avatar Jul 11 '19 18:07 nukeop

Thanks :) Well, I've translated most of the strings but some of the strings contain words or phrases that should remain be in english, even after the translation (like "API", "Last.fm" and so on). In these cases, when the string contain english and hebrew both, There is a RTL issue. So I think that these strings will remain in english and in the future we can add some css fixes for RTL version (and then I'll translate the mixed strings). What do you think? :)

avirec avatar Jul 14 '19 06:07 avirec

Ok, I'll look into it and how to handle it best.

nukeop avatar Jul 15 '19 19:07 nukeop

For reference: https://langsolinc.com/rtl-language-direction-in-css-basics/

nukeop avatar Jul 15 '19 19:07 nukeop

Hi I just translated some phrases into Chinese, and made a pull request. Link is here

hedyhli avatar Jul 16 '19 03:07 hedyhli

Thank you, appreciated.

nukeop avatar Jul 18 '19 21:07 nukeop

@avirec https://www.i18next.com/overview/api#dir

Looks like it can be automatically detected whether or not a given language is RTL. However, this will need additional styles applied, not just to text but also to e.g. reverse the order in which buttons and labels appear in some contexts. It is likely that this will have to be developed as a separate feature.

nukeop avatar Jul 18 '19 21:07 nukeop

@nukeop Great. I can do it (I mean - the css chenges for the RTL version)

avirec avatar Jul 19 '19 12:07 avirec

Hi! I'm new to github but I'd like to help to translate it to Indonesian. How do I start?

ghost avatar Sep 04 '19 12:09 ghost

@weninglaks have a look here: https://github.com/nukeop/nuclear/wiki/Translating

nukeop avatar Sep 05 '19 21:09 nukeop

Has the translation of the Chinese version already finished? If not, I would love to contribute to it.

Thanks!

Zhenye-Na avatar Sep 16 '19 19:09 Zhenye-Na

@Zhenye-Na Nope, not yet. You can see all the needed strings here: https://github.com/nukeop/nuclear/blob/master/app/locales/zh.json

nukeop avatar Sep 16 '19 20:09 nukeop

@nukeop Great! May I work on to finish it right now? Also, are there any guidelines to start with?

Zhenye-Na avatar Sep 16 '19 20:09 Zhenye-Na

Sure, feel free to translate whatever's left. Normally you'd have to add some code to enable a new translation but this one's already in the program so you don't need to do anything other than the translation itself.

nukeop avatar Sep 17 '19 20:09 nukeop

Hi I could help with translating Chinese! Is there anything that I can contribute to or help with?

zhr1996 avatar Sep 22 '19 03:09 zhr1996

Thanks for the offer @zhr1996 ! You can find more info here: https://nukeop.gitbook.io/nuclear/contributing/translating

In the case of Chinese, you only need to translate the remaining strings, since all the other parts are already completed.

nukeop avatar Sep 22 '19 20:09 nukeop

@nukeop Thanks! I'll try to translate them and pull request!

zhr1996 avatar Sep 23 '19 20:09 zhr1996

Hi, I can contribute to translating it in Filipino (Tagalog). Is the project still accepting translations?

giftofgrub avatar Oct 01 '19 18:10 giftofgrub

Yep, of course! We don't have Filipino yet. It would be great to add it.

nukeop avatar Oct 01 '19 18:10 nukeop

Hi, gonna work on translating into Slovak language.

MartinTuroci avatar Oct 05 '19 15:10 MartinTuroci

Hey there! I would like to translate it to Korean! Let me know what you think! :)

dexterastin avatar Oct 06 '19 18:10 dexterastin

Sure, there is no Korean translation yet, it would be a fantastic addition.

nukeop avatar Oct 06 '19 19:10 nukeop

Hello, I can try to finish the remaining translation for Chinese, since there is already a zh.json file, I can just make the changes in zh.json then upload the pull request correct? do i still need to update the i18n script in packages/app/package.json by adding your locale??? thank you kindly

jqiallnatural avatar Oct 23 '19 13:10 jqiallnatural

You only need to translate the remaining strings. There will be more gaps as we add new features, so there's often something new to add.

nukeop avatar Oct 23 '19 15:10 nukeop

Hello, I could help with Greek if you want to have it :)

Shuin-San avatar Aug 21 '20 19:08 Shuin-San

Sure, we don't have Greek yet.

nukeop avatar Aug 27 '20 18:08 nukeop

I'll add Croatian translation! Just forked the repo!

pozda avatar Oct 02 '20 21:10 pozda

Thank you, this is great!

nukeop avatar Oct 03 '20 12:10 nukeop

Hello! I would like to start working on the Finnish translation if nobody haven't started it yet?

cjola002-xamk avatar Feb 16 '21 10:02 cjola002-xamk

Finnish isn't supported yet so you can do it, thanks for the help.

nukeop avatar Feb 16 '21 10:02 nukeop

Finnish isn't supported yet so you can do it, thanks for the help

Nice, thanks! I'll start working on it today.

cjola002-xamk avatar Feb 16 '21 11:02 cjola002-xamk

Hi, I can help with Japanese

azumukupoe avatar Mar 07 '21 03:03 azumukupoe

Thanks, that would be great. Please follow the translation guide.

nukeop avatar Mar 07 '21 11:03 nukeop

Hi, i updated the Korean translation (finished everything) & added a Korean translation for readme. I mentioned doing this on discord before! idk if this is the proper way to do it (newbie here), could you please check if I did it right? Thanks!

teamzamong avatar Mar 27 '21 14:03 teamzamong

From now on, new translations should be added here: https://crowdin.com/project/nuclear

nukeop avatar Jul 01 '21 08:07 nukeop

I have a very good command of the German language. On request, I can check German sentences for grammar, spelling, style & syntax.

UnixCro avatar Jul 04 '21 11:07 UnixCro

@UnixCro You can use this link to join as a proofreader: https://crowdin.com/project/nuclear/invite?d=052515j696g5i5b3s4k493t4j4

nukeop avatar Jul 04 '21 13:07 nukeop

@nukeop I would like to work in an spanish readme translation. What are the steps to follow?

amendezm avatar Aug 03 '21 20:08 amendezm

Spanish is at 100% right now, so no need to do anything: https://crowdin.com/project/nuclear

nukeop avatar Aug 03 '21 20:08 nukeop

@nukeop I mean the readme file of the repo

image image

I don't see spanish there

amendezm avatar Aug 03 '21 20:08 amendezm

In this case, just create a file named README-[locale code].md, and add a link to it in the English readme.

nukeop avatar Aug 03 '21 20:08 nukeop

@nukeop I just open a PR for this

amendezm avatar Aug 04 '21 14:08 amendezm

hi @nukeop, i would like to add translation to Latvian language. can i give it a go?

nattts avatar Oct 25 '21 05:10 nattts

@nattts - sure, thanks for the help. I added it on crowdin: https://crowdin.com/project/nuclear/lv

nukeop avatar Oct 25 '21 07:10 nukeop

I just translated Croatian, Dutch and German on CrowdIn. With a few additional checks, especially in Croatian.

Is it also possible to add Serbian and Bosnian?

SecularSteve avatar Nov 22 '21 16:11 SecularSteve

Awesome, I'll add them. How do you know so many languages?

nukeop avatar Nov 22 '21 18:11 nukeop

Bosnian, Croatian and Serbian are all much of the same, but with slight dialect differences. The only reason they're proclaimed different today is because of complicated socio-political reasons.

I already had experience with English and German, so learning Dutch was automatically a breeze.

SecularSteve avatar Nov 22 '21 20:11 SecularSteve

Hi @nukeop Just translated and finished Indonesian language. Let me know if there's anything to help! i'd be glad to do so :D

altela avatar Dec 23 '21 10:12 altela

I was hoping for adding a translation in my native language, Bengali.

FahimFBA avatar Jan 30 '22 16:01 FahimFBA

Ok, I added Bengali on Crowdin, you should be able to start translating.

nukeop avatar Jan 30 '22 17:01 nukeop

Hi Please add Persian language to Crowdin. Thanks

rm-NoobInCoding avatar Aug 02 '22 13:08 rm-NoobInCoding

Thanks for the suggestion, I added it.

nukeop avatar Aug 02 '22 13:08 nukeop