nuclear icon indicating copy to clipboard operation
nuclear copied to clipboard

Full screen visualizer opacity

Open NicolasGuruphat opened this issue 1 year ago • 17 comments

Platform: Windows Nuclear version: v0.6.24 Description of the issue: When the visualizer is in full screen, there is a grey effect over the image image

NicolasGuruphat avatar Jul 13 '23 17:07 NicolasGuruphat

You're right that this is a bug, I've never considered this because when using the visualizer I just move the cursor to another monitor.

This needs to be fixed in the following way:

  • Remove the hover css styles from the overlay element
  • Instead, use setTimeout and add a mouse event listener that checks if the mouse has moved over this element. If it moved, set a timer for 3-5s, and apply the dark overlay
  • When the timer expires, remove the overlay again
  • Can probably be done using useEffect

nukeop avatar Jul 13 '23 17:07 nukeop

I want to work on this issue could you please assign it to me ?

lalitkumawat1m avatar Jul 14 '23 16:07 lalitkumawat1m

Sure, please also check this: https://nukeop.gitbook.io/nuclear/contributing/contribution-guidelines

nukeop avatar Jul 14 '23 20:07 nukeop

Im facing issue in installing project my computer is showing that it is harmful for system

ScreenShot Screenshot 2023-07-15 205842

I have downloaded nuclear.Setup.0.6.24.exe file from https://github.com/nukeop/nuclear/releases could you please tell me how to install it and what are the steps to reproduce this bug

lalitkumawat1m avatar Jul 15 '23 15:07 lalitkumawat1m

Looks like a Windows problem

nukeop avatar Jul 15 '23 16:07 nukeop

Yes it is. You can force the installation by clicking more info

NicolasGuruphat avatar Jul 17 '23 07:07 NicolasGuruphat

Are you still working on this @lalitkumawat1m ? I may try to fix it this weekend.

NicolasGuruphat avatar Jul 19 '23 14:07 NicolasGuruphat

Are you still working on this @lalitkumawat1m ? I may try to fix it this weekend.

You can work on this issue

lalitkumawat1m avatar Jul 19 '23 15:07 lalitkumawat1m

@nukeop can you assign this to me?

Bhuminandan avatar Aug 13 '23 12:08 Bhuminandan

No

nukeop avatar Aug 13 '23 12:08 nukeop

@nukeop Is someone already working on it?

Bhuminandan avatar Aug 13 '23 12:08 Bhuminandan

No, but I don't see any Typescript code in your contributions, and I am no longer accepting contributions from random Github accounts.

nukeop avatar Aug 13 '23 12:08 nukeop

@nukeop Thank you for clarification. I must admit that I'm not familiar with TypeScript at the moment, I will try to find something related to js for now!

Bhuminandan avatar Aug 13 '23 12:08 Bhuminandan

Hello, @nukeop Can you please assign this issue to me I want to work on this. I assure that I will solve this.

soumya-ranjan-pratap avatar Oct 02 '23 08:10 soumya-ranjan-pratap

I don't assign issues anymore. Just open a PR.

nukeop avatar Oct 02 '23 08:10 nukeop

How do I get permission to push a new branch and create a PR then @nukeop ?

GuillotJessica avatar Nov 27 '23 17:11 GuillotJessica

Hiya, on Github you need to fork the repository first (top right). Then you get your own copy of the repo that you can push to, and after that you can open a pull request against my original repo.

nukeop avatar Nov 27 '23 21:11 nukeop

Closed by #1563

nukeop avatar Mar 03 '24 15:03 nukeop