nuclear
nuclear copied to clipboard
nukeop
Add option to hide tray/menu bar icon
Hi,
Is there any way that an option could be added to hide the tray icon on Windows and the menu bar icon on macOS/Linux if you don't wish to have it enabled?
Thanks in advance!
I have other things I want to work on but I don't see why not if anyone wants to contribute this option.
Hello, I tried figuring this one out as one of my first public contributions. I've managed to make a toggle switch for showing the icon in the feature/toggle-tray-icon branch in my fork. At the moment it only shows/hides the icon after restarting. Also it's still using it's prettyName value in the settings menu. The program seems to be running normally still but npm test is failing a single test right now on my end.
Can you please add tests for this feature? And if you open a pull request, we can run CI to figure out which tests are failing and why.
I'll try making some tests. Could you point me towards where some examples are in the project so I can look at how they are made? As for the pull request, should I do it now or after the tests are made?
You can look at any file with .test. Feel free to open a PR whenever you want.
Sure, just please read the contribution guidelines first: https://nukeop.gitbook.io/nuclear/contributing/contribution-guidelines
@nukeop I have a couple of questions. The first is that I'm failing a test right now, but it seems like the last merged pull request on the main repo also failed this test so I'm not sure what I should do about that. Also, same as the last person, I'm still using the pretty name and don't know whether I should be adding translations or not. I'll put in a pull request really soon if you want to go from there as well. Thanks.