nue icon indicating copy to clipboard operation
nue copied to clipboard

`router` fails if URL has hash (#) fragment

Open gapmiss opened this issue 1 year ago • 4 comments

Testing out nuemark and having issues with the page router.

For example:

A page with a nuemark tabs component http://localhost:8080/index.html

click a tab and the url changes to http://localhost:8080/index.html#tab-1

click link to a different page http://localhost:8080/example.html

click browser's back button and the URL is again http://localhost:8080/index.html#tab-1

however, the page content is still from the example.html

screencast:

CleanShot-Firefox-Markdown with megapowers-2024-01-13-09 07 13

gapmiss avatar Jan 13 '24 14:01 gapmiss

Ahh... good catch. I forgot to implement the collaboration between the tabs component and the page-router. Thanks!

tipiirai avatar Jan 15 '24 06:01 tipiirai

Forgive me I might be off-topic, but I'm borrowing the topic of "page_router":

Is the page_router in site.yaml now deprecated in favor of router: true|false? I'm seeing only if (data.router) push('page_router')...

But there are still two places that using page_router: true in create-www

fritx avatar Apr 18 '24 02:04 fritx

@fritx yes, it has been replaced. See #113 with its closing commit https://github.com/nuejs/nue/commit/be2f19ae0dc564759570c38771ab47bb41f35f63. Then this should be corrected in create and www

nobkd avatar Apr 18 '24 09:04 nobkd

Wrongly closed. Sry.

nobkd avatar Aug 18 '24 22:08 nobkd