nucliadb icon indicating copy to clipboard operation
nucliadb copied to clipboard

Fix x-sync header bug

Open lferran opened this issue 3 years ago • 1 comments

Description

Some things needed fixing to make the feature work:

  • Convert sync callbacks to async for nats aio subscribe callbacks.
  • Bump redis aio library to support async callbacks.
  • Change the way transaction was getting the pubsub utility.

How was this PR tested?

  • Added an integration test replicating the production environment (tikv as main storage and nats as pubsub).

lferran avatar Oct 19 '22 11:10 lferran

Codecov Report

Base: 67.25% // Head: 67.22% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (86bd7a4) compared to base (02987bf). Patch coverage: 67.39% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
- Coverage   67.25%   67.22%   -0.03%     
==========================================
  Files         209      209              
  Lines       14089    14106      +17     
==========================================
+ Hits         9475     9483       +8     
- Misses       4614     4623       +9     
Flag Coverage Δ
ingest 51.00% <20.00%> (-0.04%) :arrow_down:
node-sidecar 68.43% <ø> (ø)
nucliadb 52.58% <71.42%> (-0.01%) :arrow_down:
one 89.41% <100.00%> (+0.12%) :arrow_up:
reader 63.68% <ø> (ø)
search 83.12% <ø> (ø)
train 32.71% <ø> (ø)
utils 48.17% <66.66%> (-0.02%) :arrow_down:
writer 78.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nucliadb_utils/nucliadb_utils/cache/utility.py 72.81% <0.00%> (-0.72%) :arrow_down:
nucliadb_utils/nucliadb_utils/transaction.py 28.94% <0.00%> (ø)
nucliadb_utils/nucliadb_utils/cache/nats.py 63.93% <46.15%> (-2.74%) :arrow_down:
nucliadb/nucliadb/ingest/metrics/service.py 73.33% <50.00%> (-4.45%) :arrow_down:
nucliadb_utils/nucliadb_utils/utilities.py 48.61% <91.66%> (+0.69%) :arrow_up:
nucliadb/nucliadb/ingest/maindb/redis.py 92.24% <100.00%> (ø)
nucliadb/nucliadb/one/lifecycle.py 100.00% <100.00%> (ø)
nucliadb/nucliadb/writer/tus/dm.py 81.39% <100.00%> (ø)
nucliadb_utils/nucliadb_utils/cache/pubsub.py 64.70% <100.00%> (+2.20%) :arrow_up:
nucliadb_utils/nucliadb_utils/cache/redis.py 90.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 19 '22 11:10 codecov[bot]