[do not merge] Change rag images strategies default
Description
Do not merge until 11th of November.
How was this PR tested?
Describe how you tested this PR.
Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
Project coverage is 86.19%. Comparing base (
8ee8c64) to head (ac3a9d4). Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| nucliadb_models/src/nucliadb_models/search.py | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2572 +/- ##
==========================================
+ Coverage 86.17% 86.19% +0.02%
==========================================
Files 377 377
Lines 23791 24052 +261
==========================================
+ Hits 20501 20732 +231
- Misses 3290 3320 +30
| Flag | Coverage Δ | |
|---|---|---|
| nucliadb | 73.67% <ø> (+<0.01%) |
:arrow_up: |
| nucliadb-ingest | 28.51% <ø> (ø) |
|
| nucliadb-reader | 24.54% <ø> (ø) |
|
| nucliadb-search | 37.61% <ø> (-0.02%) |
:arrow_down: |
| nucliadb-standalone | 46.61% <ø> (ø) |
|
| nucliadb-train | 44.74% <ø> (ø) |
|
| nucliadb-writer | 39.13% <ø> (ø) |
|
| nucliadb_dataset | 55.45% <ø> (ø) |
|
| nucliadb_models | 85.09% <ø> (ø) |
|
| nucliadb_sdk | 80.11% <ø> (ø) |
|
| nucliadb_sidecar | 89.03% <ø> (ø) |
|
| nucliadb_telemetry | 86.55% <ø> (ø) |
|
| nucliadb_utils | 84.36% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think we will need to revert the changes I did here as well! https://github.com/nuclia/nucliadb/pull/2175
Before the strategy was not set as default but the docs said the default behavior was to send images so that PR added the default functionality. Now I see that afterwards the default parameter was changed