nucliadb icon indicating copy to clipboard operation
nucliadb copied to clipboard

ORM-datamanagers improvements

Open jotare opened this issue 1 year ago • 1 comments

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

jotare avatar Jul 08 '24 14:07 jotare

Codecov Report

Attention: Patch coverage is 90.12346% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.28%. Comparing base (14a5338) to head (205bf6d). Report is 325 commits behind head on main.

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/ingest/orm/knowledgebox.py 83.33% 4 Missing :warning:
nucliadb/src/nucliadb/writer/back_pressure.py 0.00% 2 Missing :warning:
...cliadb/src/nucliadb/common/datamanagers/cluster.py 94.11% 1 Missing :warning:
...iadb/src/nucliadb/common/datamanagers/resources.py 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2292      +/-   ##
==========================================
+ Coverage   86.22%   86.28%   +0.05%     
==========================================
  Files         358      358              
  Lines       21972    21967       -5     
==========================================
+ Hits        18946    18954       +8     
+ Misses       3026     3013      -13     
Flag Coverage Δ
nucliadb 72.39% <87.65%> (+0.12%) :arrow_up:
nucliadb-reader 24.92% <54.32%> (+<0.01%) :arrow_up:
nucliadb-search 32.12% <50.61%> (+0.02%) :arrow_up:
nucliadb-standalone 48.00% <51.85%> (+0.04%) :arrow_up:
nucliadb-train 46.67% <55.55%> (+0.02%) :arrow_up:
nucliadb-writer 38.28% <59.25%> (+0.02%) :arrow_up:
nucliadb_dataset 60.09% <ø> (ø)
nucliadb_models 85.37% <ø> (ø)
nucliadb_sdk 77.48% <ø> (ø)
nucliadb_sidecar 94.23% <ø> (ø)
nucliadb_telemetry 86.57% <ø> (ø)
nucliadb_utils 83.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 15 '24 14:07 codecov[bot]

I think there were nice improvements but rollover and some other unit tests were awfully hard to get right... As it's been more than half year open without changes, I'll close it

jotare avatar Nov 27 '24 14:11 jotare