nucliadb icon indicating copy to clipboard operation
nucliadb copied to clipboard

WIP: add processor cleanup task handler

Open vangheem opened this issue 1 year ago • 1 comments

Description

This is an example of what we need to do in order to prevent deleted resources from being processed unnecessarily.

Can we do the same for...

  • on prem
  • entire kbs

How was this PR tested?

Describe how you tested this PR.

vangheem avatar Jan 25 '24 00:01 vangheem

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (59d028d) 82.13% compared to head (6469574) 82.07%.

Files Patch % Lines
...iadb/nucliadb/ingest/consumer/processor_cleanup.py 56.52% 10 Missing :warning:
...ucliadb/nucliadb/common/http_clients/processing.py 12.50% 7 Missing :warning:
nucliadb/nucliadb/ingest/consumer/service.py 28.57% 5 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1771      +/-   ##
==========================================
- Coverage   82.13%   82.07%   -0.06%     
==========================================
  Files         335      336       +1     
  Lines       19682    19720      +38     
==========================================
+ Hits        16166    16186      +20     
- Misses       3516     3534      +18     
Flag Coverage Δ
ingest 68.91% <50.00%> (-0.15%) :arrow_down:
nucliadb 70.11% <42.10%> (-0.03%) :arrow_down:
reader 79.82% <ø> (ø)
sdk 40.64% <ø> (ø)
standalone 88.29% <ø> (ø)
train 63.60% <ø> (ø)
utils 81.42% <ø> (ø)
writer 85.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 25 '24 01:01 codecov[bot]