nucliadb icon indicating copy to clipboard operation
nucliadb copied to clipboard

Add PrometheusMetricObserver abstraction

Open jotare opened this issue 10 months ago • 2 comments

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

jotare avatar Oct 04 '23 07:10 jotare

This pull request has been linked to Shortcut Story #7440: Nucliadb metrics refinement.

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (b9c5ecd) 84.89% compared to head (6658f87) 85.20%. Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1421      +/-   ##
==========================================
+ Coverage   84.89%   85.20%   +0.31%     
==========================================
  Files         443      450       +7     
  Lines       24273    24810     +537     
==========================================
+ Hits        20606    21139     +533     
- Misses       3667     3671       +4     
Flag Coverage Δ
ingest 74.89% <ø> (+0.21%) :arrow_up:
nucliadb 68.24% <ø> (+0.75%) :arrow_up:
reader 75.94% <ø> (-0.26%) :arrow_down:
train 60.25% <ø> (ø)
utils 85.18% <ø> (+<0.01%) :arrow_up:
writer 83.97% <ø> (-0.73%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 30 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 04 '23 07:10 codecov[bot]