enaml icon indicating copy to clipboard operation
enaml copied to clipboard

Published 20 hours ago • verified publisher icon nucleic

button_group

Open mervecelik11 opened this issue 3 years ago • 4 comments

mervecelik11 avatar Oct 23 '22 16:10 mervecelik11

Could you motivate your changes ?

MatthieuDartiailh avatar Oct 23 '22 18:10 MatthieuDartiailh

Do not worry about the CI failure I will take care of it.

MatthieuDartiailh avatar Oct 24 '22 09:10 MatthieuDartiailh

Thank you

mervecelik11 avatar Oct 24 '22 11:10 mervecelik11

Reading through your changes it seems you have misinterpreted the goal of the example, which means it can be improved.

This example demonstrate how radio buttons living in different containers can still be grouped. Radio buttons living in the same container are grouped by default which is not demonstrated by this example and maybe it should. Your changes make use of this mechanism but completely remove the original intent of the example.

We should try to expand the example to do both: demonstrate the default behavior and the more flexible one.

MatthieuDartiailh avatar Oct 24 '22 20:10 MatthieuDartiailh