ember-elm icon indicating copy to clipboard operation
ember-elm copied to clipboard

Change project structure?

Open MattCheely opened this issue 6 years ago • 8 comments

One thing that got a bit more difficult with the move to 0.19 is testing. With support for tests more closely built into the package format, elm-test is now more rigorous about where tests live, expecting them directly in tests/ at the project root, where Ember also likes to keep other test structures.

It might be cleaner to completely separate out Elm into it's own sub-project, and add some Ember-CLI commands to manage package installs and such. Would you be open to a PR with those changes?

MattCheely avatar Sep 11 '18 01:09 MattCheely

Yeah definitely!

I'd also be open to adding you as a maintainer if you're interested. 🙂 Just so I'm not the blocker for any of the changes you want to make.

nucleartide avatar Sep 12 '18 22:09 nucleartide

Does this mean it's going to be upgraded to 0.19?

ondrejsevcik avatar Sep 13 '18 09:09 ondrejsevcik

@nucleartide Yeah, I'd be happy to be a maintainer, thanks!

@ondrejsevcik already done in #21! Just needs to be published to npm.

MattCheely avatar Sep 14 '18 17:09 MattCheely

@MattCheely Cool! Lemme add you to the repo. I'll also give you publish rights, lemme set a reminder.

nucleartide avatar Sep 14 '18 20:09 nucleartide

@MattCheely Added you to the npm repo as well!

nucleartide avatar Sep 15 '18 17:09 nucleartide

@nucleartide Thanks!

MattCheely avatar Sep 15 '18 18:09 MattCheely

@ondrejsevcik Took me a while to get around to it, but I've finally published support for Elm 0.19 to npm as [email protected]

MattCheely avatar Sep 23 '18 14:09 MattCheely

No worries and big thanks 🙏🏽

ondrejsevcik avatar Sep 24 '18 06:09 ondrejsevcik