Erik Little comments

Results 128 comments of


                                            Erik Little

Protobuf

I'll look into what can be done

build warning: XCode 12 support only IPHONEOS_DEPLOYMENT_TARGET from 9.0 to 14.0.99

Will be fixed by #1309

Token object arrives as query and not in the correct header

@RoeelCohen have you tried using [.extraHeaders](https://nuclearace.github.io/Socket.IO-Client-Swift/Enums/SocketIOClientOption.html#/s:8SocketIO0A14IOClientOptionO12extraHeadersyACSDyS2SGcACmF)?

Token object arrives as query and not in the correct header

@RoeelCohen Yes I would use `extraHeaders` for this. Does that solve your issue?

SocketClient deinit never called.

Are you capturing a strong reference to your client in a handler somewhere?

SocketClient deinit never called.

Could you turn on logs and post the logs for the manager/client when it's trying to disconnect?

SocketClient deinit never called.

This simple example doesn't show the manager or engine holding a strong reference. So would either be something on your end, on something involving ACKs, or more complex example. ```swift...

SocketClient deinit never called.

Ah, so it's something in the Acks.

SocketClient deinit never called.

What does your ack callback look like?

SocketClient deinit never called.

Hmm, I wonder if it has to with this bit of code: ```swift /// Completes an emitWithAck. If this isn't called, the emit never happens. /// /// - parameter seconds:...