nDPI icon indicating copy to clipboard operation
nDPI copied to clipboard

feat: replace old readable string extraction with new filtered multi-string support

Open fabiodepin opened this issue 9 months ago • 3 comments

Please sign (check) the below before submitting the Pull Request:

[ X ] I have signed the ntop Contributor License Agreement at https://github.com/ntop/legal/blob/main/individual-contributor-licence-agreement.md [ X ] I have read the contributing guidelines at https://github.com/ntop/nDPI/blob/dev/CONTRIBUTING.md [ ] I have updated the documentation (in doc/) to reflect the changes made (if applicable)

Link to the related issue: References https://github.com/ntop/nDPI/issues/2708

Describe changes:

Feat: add extract_readable_strings with advanced filtering; refactor string handling

  • Introduces a new function to retrieve multiple human-readable substrings from a payload, with optional filter callback support (e.g., for FQDN detection).
  • Replaces the old function with the new approach.
  • Increases size from 32 to 128 bytes to support longer string concatenations.
  • Renames all occurrences of to the correct spelling .
  • Replaces all calls to with , reflecting the new logic.

fabiodepin avatar Apr 01 '25 23:04 fabiodepin

@fabiodepin, could you take a look at the errors in the regression tests, please?

IvanNardi avatar Apr 05 '25 09:04 IvanNardi

@fabiodepin, could you take a look at the errors in the regression tests, please?

Hi, sure. I'll check and get back to you.

fabiodepin avatar Apr 08 '25 13:04 fabiodepin