nDPI icon indicating copy to clipboard operation
nDPI copied to clipboard

Hangout: avoid useless lookups in the protocol tree

Open IvanNardi opened this issue 2 years ago • 2 comments

We already performed exactly these lookups in the generic code to populate flow->guessed_protocol_id_by_ip: use it!

This code probably needs a deeper review, since it is basicaly a simple matching on ip + port.

IvanNardi avatar Sep 26 '22 12:09 IvanNardi

The review will take some time.

utoni avatar Sep 28 '22 19:09 utoni

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 25 '22 15:10 sonarqubecloud[bot]