ignorable icon indicating copy to clipboard operation
ignorable copied to clipboard

ingorable should fail fast on rails >= 5.1.6 with explanation

Open eiked opened this issue 6 years ago • 0 comments

Hi nthj, Big thanks for the ingorable gem. I found out, that this is now included since rails 5

It did still work with prior versions of rails 5 but since rails 5.1.6 it crashes rails (see below)

I'd like to suggest that the ignorable gem should be updated:

  • to fail fast when run on rails >= 5.1.6
  • to show a deprecation warning when run on rails 5 .. < 5.1.6

and give an explanation how to fix the problem, aka how to migrate to the syntax in rails 5.

There is no good description in the rails docs, yet. You might also want to update your readme.

This is how the bug shows up on crash:

ruby2.5/gems/2.5.0/gems/activerecord-5.1.6/lib/active_record/relation/query_methods.rb:1044:in build_select': undefined method any?' for nil:NilClass (NoMethodError)

eiked avatar Apr 11 '18 20:04 eiked