papermill icon indicating copy to clipboard operation
papermill copied to clipboard

Do an audit of requirements files, pyproject.toml, ci config, tox

Open willingc opened this issue 1 year ago • 5 comments

We seem to have added some complexity and it probably makes sense to audit these workflows.

willingc avatar Nov 15 '23 12:11 willingc

If I am understanding correctly, everything in requirements folder is dev and extras. The requirements.txt is the base requirements to build papermill. The docs/requirements.txt should have both the docs requirements and the package requirements which doesn't currently work. Does that align with other's understanding.

willingc avatar Nov 15 '23 12:11 willingc

I'm going to when I have time...try to switch this to the more modern packaging format. I think if we use hatch we can get rid of a bunch of stuff including tox and slim down the config files and lean more into pyproject.toml. This should improve maintainability.

willingc avatar Nov 16 '23 19:11 willingc

Yes I think Python3.13 might force the issue anyway, but I agree we need to redo the setup.py / requirements pattern.

MSeal avatar Nov 17 '23 23:11 MSeal

Would you be in favor of moving out of tox? and using pure pytest and GHA?

Borda avatar Nov 21 '23 12:11 Borda

Maintainer of Hatch and Hatchling here! Let me know if I can be of assistance 🙂

ofek avatar Dec 06 '23 00:12 ofek