papermill icon indicating copy to clipboard operation
papermill copied to clipboard

Wrongly creates a log even if log_output is False

Open huzzahforjulia opened this issue 6 years ago • 1 comments

Currently, in papermill/execute.py, the log_output parameter is unused. Even if it is set to false, it still writes output to the configured logger.

This means that Input Notebook and Output Notebook are logged every single time a worker notebook is run. There should be a toggle to turn this output off (ie, add an if statement that checks if log_output is true before logging these values).

huzzahforjulia avatar Nov 06 '19 21:11 huzzahforjulia

The log_output is a little more specific of a flag:

@click.option( '--log-output/--no-log-output', default=False, help="Flag for writing notebook output to the configured logger.", )

It's to control the notebook's output, not papermill's output.

The log_evel option controls what log level the CLI defaults to:

@click.option( '--log-level', type=click.Choice(['NOTSET', 'DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL']), default='INFO', help='Set log level', )

If you're calling papermill from a python process and not the cli you can control logging by standard means of the logging library. https://www.loggly.com/ultimate-guide/python-logging-basics/ gives a good guide on this.

MSeal avatar Dec 30 '19 03:12 MSeal