data-explorer icon indicating copy to clipboard operation
data-explorer copied to clipboard

Data Explorer: Scatterplot size ignored in Firefox

Open dylanross3 opened this issue 5 years ago • 6 comments

Application or Package Used Data Explorer

Describe the bug Selecting a size for points in the Scatterplot chart type has no effect in Firefox. Works fine in Chrome.

To Reproduce Steps to reproduce the behavior:

  1. Go here to load the "Happiness" example notebook
  2. Select the Scatterplot chart type
  3. Select something in the Size dropdown
  4. See the points do not resize in Firefox

Expected behavior The points should resize in Firefox. It should look pretty close to how it looks in Chrome.

Screenshot - Firefox (not correct) image

Screenshot - Chrome (correct) image

dylanross3 avatar Apr 25 '19 01:04 dylanross3

Apparently, Firefox hasn't implemented setting r via CSS style: https://stackoverflow.com/questions/51551729/styling-of-svg-circle-doesn%C2%B4t-work-in-firefox-browser-removes-radius-property?noredirect=1&lq=1

This will require a patch release to Semiotic in order to pass the radius as an attribute as well as via style but it's a minor change.

emeeks avatar Apr 27 '19 03:04 emeeks

@dylanross3 when you get a chance pull the latest version and let me know if this resolves the problem. I tested it locally and seems to be fine but I just want to make sure.

emeeks avatar May 17 '19 00:05 emeeks

Reopening. I thought this was fixed but that's only for initial render. When I change which field is selected for size, the diameter of the data points does not update in Firefox. As a workaround, switching to another chart type and back produces the expected visualization.

dylanross3 avatar Jun 24 '19 18:06 dylanross3

This issue hasn't had any activity on it in the last 90 days. Unfortunately we don't get around to dealing with every issue that is opened. Instead of leaving issues open we're seeking to be transparent by closing issues that aren't being prioritized. If no other activity happens on this issue in one week, it will be closed. It's more than likely that just by me posting about this, the maintainers will take a closer look at these long forgotten issues to help evaluate what to do next. If you would like to see this issue get prioritized over others, there are multiple avenues 🗓:

  • Ask how you can help with this issue 👩🏿‍💻👨🏻‍💻
  • Help solve other issues the team is currently working on 👨🏾‍💻👩🏼‍💻
  • Donate to nteract so we can support developers to work on these features and bugs more regularly 💰🕐

Thank you!

stale[bot] avatar Apr 19 '20 19:04 stale[bot]

Transferring to data explorer repo.

captainsafia avatar Apr 21 '20 01:04 captainsafia

Triaging as "needs: testing" to determine if this is still an issue.

willingc avatar Jun 04 '21 22:06 willingc