commuter icon indicating copy to clipboard operation
commuter copied to clipboard

[TypeScript Reference] Attempt to sync netflix typescript changes into working branch (NO MERGE)

Open MSeal opened this issue 5 years ago • 4 comments

I have not made this branch run yet, just doing a dump of changes made on the netflix fork internally somewhere it can be evaluated for use in commuter open source. The code changed pretty dramatically in how it handled typescript assets and organized some things so I didn't bother with trying to merge git histories. Likely many of the changes need to use the current master code instead, but we can discuss what to do with the branch at our next sync meeting.

MSeal avatar May 20 '20 00:05 MSeal

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

I don't think we should merge it right away but we can use some of this code when migrating the codebase to TypeScript.

Totally agree! This code is also likely more out of date than if we switched things over again now.

rgbkrk avatar Jun 07 '20 22:06 rgbkrk

I changed the title to better reflect the state of the code changes. I think we should leave this open while doing typescript improvments as a references?

MSeal avatar Jun 08 '20 23:06 MSeal

Yep. This comment has more info about our action plan.

captainsafia avatar Jun 10 '20 02:06 captainsafia