tiny11builder icon indicating copy to clipboard operation
tiny11builder copied to clipboard

Please add multilanguage support

Open Elrondo46 opened this issue 1 month ago • 8 comments

Can you add this possibility or make a howto about that ?

Elrondo46 avatar Apr 22 '24 14:04 Elrondo46

In theory the new PowerShell script is supposed to automatically detect the language of the image and act accordingly.

ntdevlabs avatar Apr 22 '24 16:04 ntdevlabs

Not true. Downloaded a french edition results generating a US edition

Elrondo46 avatar Apr 22 '24 20:04 Elrondo46

Default system UI language code not found.

This is the error

Elrondo46 avatar Apr 22 '24 21:04 Elrondo46

same for German (de-de) Cause is dism-cmd in line 58 gives out localized information. Add parameter /English at the end of this line so the output is english and the regex matches.

Wasp5016 avatar Apr 23 '24 18:04 Wasp5016

Will look into it. Thanks for your patience!

ntdevlabs avatar Apr 23 '24 18:04 ntdevlabs

This might sound like a cliche, but... it works for me! I tried making an ISO from the Romanian release of Windows 11 and it worked flawlessly. Screenshot 2024-04-23 222127 Windows 11-2024-04-23-22-47-18

ntdevlabs avatar Apr 23 '24 19:04 ntdevlabs

@ntdevlabs For me the image creation also worked - however the app removal step did not work as intended due to this issue.

The problematic line in my case is if ($_ -match 'PackageName : (.*)') {, this line works only correctly, if the output of dism is in English, but e.g. on my machine it is in German. Consequently the $packages variable remains empty, resulting in none of the provisioned apps getting removed.

Please see my PR #140 which incorporates the fix suggested by @Wasp5016 for all calls of dism.

bwRavencl avatar Apr 23 '24 22:04 bwRavencl

For the Chinese version of the mirror, although this error occurred, there is no problem after installation.

bai0012 avatar Apr 24 '24 11:04 bai0012