tiny11builder icon indicating copy to clipboard operation
tiny11builder copied to clipboard

Minor Issue Regarding Filepaths with spaces for Batch Scripts

Open TheBigFailure opened this issue 1 year ago • 1 comments

The batch scripts used to automate the installation process all have a line that's similar to this:

echo Creating ISO image...
%~dp0oscdimg.exe -m -o -u2 -udfver102 -bootdata:2#p0,e,bc:\tiny11\boot\etfsboot.com#pEF,e,bc:\tiny11\efi\microsoft\boot\efisys.bin c:\tiny11 %~dp0tiny11.iso
echo Creation completed! Press any key to exit the script...

Which doesn't work when a space is in a folder. E.g., if the ISO destination is in a user folder and the Username has a space in it, it causes the issue [PATH] is not recognized as an internal or external command, operable program or batch file.

For example, if my username was "abc def", then it'd give me an error along the lines of 'C:\Users\abc' is not recognized as an internal or external command, operable program or batch file.

I'm not fluent with batch, but maybe consider changing

%~dp0oscdimg.exe -m -o -u2 -udfver102 -bootdata:2#p0,e,bc:\tiny11\boot\etfsboot.com#pEF,e,bc:\tiny11\efi\microsoft\boot\efisys.bin c:\tiny11 %~dp0tiny11.iso

to

%~dp0oscdimg.exe -m -o -u2 -udfver102 -bootdata:2#p0,e,bc:\tiny11\boot\etfsboot.com#pEF,e,bc:\tiny11\efi\microsoft\boot\efisys.bin c:\tiny11 "%~dp0tiny11.iso"

or something equivalent... thanks!

TheBigFailure avatar Jan 04 '24 03:01 TheBigFailure

You need to add " to the first path to solve that issue, but for the iso path " is needed too "%~dp0oscdimg.exe" -m -o -u2 -udfver102 -bootdata:2#p0,e,bc:\tiny11\boot\etfsboot.com#pEF,e,bc:\tiny11\efi\microsoft\boot\efisys.bin c:\tiny11 "%~dp0tiny11.iso"

If oscdimg was able to handle space in path, we could even use any path to extract the image files image https://learn.microsoft.com/en-us/windows-hardware/manufacture/desktop/oscdimg-command-line-options?view=windows-11#cd-or-dvd-boot-options

APT-ZERO avatar Jan 07 '24 07:01 APT-ZERO