react-weekday-picker icon indicating copy to clipboard operation
react-weekday-picker copied to clipboard

Published 20 hours ago • verified publisher icon ntdb

on latest React, WeekdayPicker throws unknown prop errors for onTouchTap

Open ragesoss opened this issue 8 years ago • 5 comments

After upgrading to React 15.4.1, I get this error whenever a WeekdayPicker renders:

       Warning: Unknown prop `onTouchTap` on <button> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
           in button (created by WeekdayPicker)

ragesoss avatar Dec 05 '16 23:12 ragesoss

@ntdb: the Wiki Ed Dashboard doesn't use the onTouchTap feature. Maybe it could be removed altogether, or conditionally assigned to the button only if present?

Currently it breaks our Poltergeist tests when the front-end is built in development mode.

ragesoss avatar Dec 11 '16 17:12 ragesoss

@ntdb ping :-)

ragesoss avatar Jan 31 '17 21:01 ragesoss

@ragesoss I would be happy to merge and publish a PR! This library is pretty far out of date at this point and it's tough for me to keep up when I'm not using it regularly, sorry about that. The react-day-picker repo this is based off of abandoned onTouchTap a while ago for onTouchStart and onTouchEnd.

ntdb avatar Apr 14 '17 05:04 ntdb

@ntdb thanks Nate! A PR was on my todo list, but if it's more broadly out of date, it'll probably make more sense to just copy it into the app and maintain it from there. What do you think?

ragesoss avatar Apr 14 '17 17:04 ragesoss

@ragesoss you totally have my blessing to do that. If I pick this library back up in the future I'll definitely look at what you're doing first.

ntdb avatar Apr 14 '17 18:04 ntdb