sweyer icon indicating copy to clipboard operation
sweyer copied to clipboard

Removing all items from queue behaves unexpected

Open Abestanis opened this issue 3 years ago • 2 comments

Removing all items from a queue reverts the queue to an `All tracks` queue and fills it with all tracks.

Removing item from queue reverts queue to all tracks

This is unexpected behavior, I would have expected the queue screen and player screen to close and no song to play.

The current behavior is especially weird when removing all items from the `All tracks` queue.

Removing all from all tracks queue does nothing

The app just freezes for a second and then re-adds every track.

Abestanis avatar May 18 '22 20:05 Abestanis

I would have expected the queue screen and player screen to close and no song to play.

When this happens I coded this for it to stop the playback, if this doesn't happen - this is a bug. The idea was that having an empty queue is invalid, and I'm not sure I want to change this. Closing the player route seems like kind of an annoying behavior compared to just resetting the queue and stopping playback.

The current behavior is especially weird when removing all items from the All tracks queue.

This likely should be fixed by optimizing the operation of removing from the queue

nt4f04uNd avatar May 20 '22 19:05 nt4f04uNd

When this happens I coded this for it to stop the playback

It is stopping, that part is ok.

This likely should be fixed by optimizing the operation of removing from the queue

I think optimizing this is a good idea, but it will make things even worse. Because then all the user sees is just closing the selection screen. It feels like the request to remove everything didn't work, like it's a bug.

Closing the player route seems like kind of an annoying behavior

For me this feels like a natural step. If I remove the last item from a queue, there is no more queue. It is definitely more expected than having my queue filled by something else. It just doesn't make sense to me that removing an element from a queue would fill it.

Abestanis avatar May 20 '22 20:05 Abestanis