livemarks icon indicating copy to clipboard operation
livemarks copied to clipboard

feed figure included image styles missing

Open ophian opened this issue 4 years ago • 3 comments

non-public. URL Sorry! version: 3.2

My feeds have possible html "figure/figcaption" tags around some images for comments. It does need the following addition to the reader.css;

.item figure {
    display: inline;
}

and change the max-width of:

.item img {
  max-width: 50%;
  height: auto;
  vertical-align: middle;
}

to

.item img {
  max-width: 100%;
  height: auto;
  vertical-align: middle;
}

which works well with all others too. Thanks!

ophian avatar Jan 29 '21 10:01 ophian

Thanks for the suggestion. I think this might not work well for us however. The idea was, I think, for text to flow around images located on the left side. A few feeds have small thumbnail sized images that shouldn't take the full width.

evilpie avatar Feb 06 '21 15:02 evilpie

No, I don't think so. It (the .item img { max-width: 100% ...) would just expand to the full image width, surrounded and influenced by its parent container(s); In my case the figure element. The feed viewer should not try to be more clever than the blogger and size images to 50% of their value. So, if you think for smaller left sided images (which was mine too) you should as well do for images that are bigger (which was also true for mine).

ophian avatar Feb 06 '21 16:02 ophian

I guess you are right. I am by no means an CSS expert. Looking https://deathclawdesu.tumblr.com/rss the text doesn't flow around the image and the image is squashed. Removing the max-width makes it look better. Please open a PR, maybe @nt1m can take a look.

evilpie avatar Feb 06 '21 16:02 evilpie