livemarks icon indicating copy to clipboard operation
livemarks copied to clipboard

Published 20 hours ago • verified publisher icon nt1m

Fix view-source URL to stop triggering preview

Open ali1234 opened this issue 4 years ago • 4 comments

Add-on version Add-on version: 3.0, Firefox 84

Describe the bug Clicking "view source" twice on any feed viewing page crashes the tab.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://feeds.bbci.co.uk/news/rss.xml
  2. Click on 'view source'
  3. Click back
  4. Click on 'view source'

Expected behavior It should not crash.

Pasting "view-source:https://feeds.bbci.co.uk/news/rss.xml" into the URL bar has the same effect. This only happens if livemarks plugin is enabled.

ali1234 avatar Dec 17 '20 09:12 ali1234

Thanks for reporting. This is a Firefox issue. https://bugzilla.mozilla.org/show_bug.cgi?id=1678734

evilpie avatar Dec 17 '20 10:12 evilpie

We might have to make some adjustments so we don't handle view-source URLs. Right now that is sadly impossible to detect in the webRequest.onHeadersReceived listener.

evilpie avatar Dec 20 '20 23:12 evilpie

Right now detecting those view-source requests is seemingly impossible in the webRequest listener. I opened a bug to make that possible https://bugzilla.mozilla.org/show_bug.cgi?id=1683646

evilpie avatar Dec 29 '20 11:12 evilpie

I decided to hide the view-source link for now, because it doesn't work anyway.

evilpie avatar Jan 24 '21 15:01 evilpie