shopify
shopify copied to clipboard
nsweeting
Add missing resources
There are still some resources missing according to this list.
Since most of them follow the same pattern, I think this is a good first issue.
EDIT: Here is a list of resources I think we are missing. This might be incomplete or accidentally list a resource we already have under a different name, so before diving in please make sure I did not make a mistake first 🙇
- [x] AbandonedCheckout (just realized this is the same as
Checkout - [x] Fulfillment :exclamation:
- [x] FulfillmentEvent
- [x] FulfillmentService
- [ ] GiftCard (Shopify PLUS only!) :zzz:
- [x] InventoryItem
- [x] InventoryLevel
- [x] Location :exclamation:
- [x] MarketingEvent
- [x] Multipass (SHOPIFY PLUS only!) :zzz:
- [x] OrderRisk
- [x] Page
- [x] Policy
- [x] ProductListing
- [x] Refund
- [x] Report
@humancopy quite a few iirc... From the top of my head I can think about Fulfillment, because I was really surprised that one wasn't already in there. I am planing to put some work into missing resources next week (golden week, yay 🏌️ ), I guess my first step will be to compile a list of missing resources.
Oh wow I see you went through most of them already! Well done! 😄
So the Shopify Plus ones you don't want to implement for now?
@humancopy I don't have a Shopify gold store, so I wouldn't be able to actually test it nor would I be using it, so I'd like to leave it to someone else to actually implement those :)
is there anything missing from adding the create method on the checkout resource?
@antonioparisi not that I am aware of. Why? Is something missing?
Edit: sorry I am on mobile, I can’t check right now. If the create function is missing, could you maybe add it and create a PR?
@Ninigi I think the checkout resource is missing the create.
https://github.com/nsweeting/shopify/blob/master/lib/shopify/resources/checkout.ex#L9
as you can see from the Shopify API docs: https://help.shopify.com/en/api/reference/sales_channels/checkout#create