nsupdate.info icon indicating copy to clipboard operation
nsupdate.info copied to clipboard

Add Dockerfile config

Open lkraider opened this issue 4 years ago • 6 comments

This adds the ability to create docker images for this project.

You probably want to change the maintainer names in the Makefile and the build/Dockerfile to your dockerhub user.

Use make test to run a local dev build of the project while developing and testing the image.

When ready, tag the current version using git and run make prod to create a production image ready to be pushed to the docker registry.

Originally based on the work done by: https://github.com/KebinuChiousu/docker-nsupdate

lkraider avatar Dec 20 '19 02:12 lkraider

Not sure I want that because I can't maintain it (I don't use docker).

@elnappo what do you think?

ThomasWaldmann avatar Dec 21 '19 15:12 ThomasWaldmann

We could move it into a /contrib folder?

elnappo avatar Dec 27 '19 15:12 elnappo

Could this live inside a misc/contrib/docker/ directory?

ThomasWaldmann avatar Dec 27 '19 17:12 ThomasWaldmann

Done, PR updated!

lkraider avatar Dec 31 '19 02:12 lkraider

Quick instructions on how to use:

  1. install docker
  2. cd misc/contrib/docker
  3. make test -> build and run a dev version
  4. docker ps -> service will be running on a random port, check the output and try to open on localhost to see if it works
  5. git tag -a 0.12.0 then make -> build a prod version (make sure to tag first to get a nice name)
  6. docker login then make release -> release on docker registry

lkraider avatar Dec 31 '19 02:12 lkraider

@elnappo can you review also?

ThomasWaldmann avatar Jan 07 '20 00:01 ThomasWaldmann