nativescript-videoplayer icon indicating copy to clipboard operation
nativescript-videoplayer copied to clipboard

Feature Request - Add an option to go FullScreen

Open bradmartin opened this issue 8 years ago • 17 comments

Need to add the ability to go Fullscreen with the video.

bradmartin avatar Apr 01 '16 14:04 bradmartin

+1

ilyago avatar Aug 03 '16 01:08 ilyago

Here is a possible solution for now https://github.com/bradmartin/nativescript-videoplayer/issues/28#issuecomment-240914968

I'll add a method to toggle 'Immersive Mode' for Android in the future.

bradmartin avatar Aug 19 '16 02:08 bradmartin

More difficult than just setting the window flags on Android. I'll try to find time to work on this later, not much free time right now. Definitely open for PRs if someone wants to work on it.

bradmartin avatar Sep 28 '16 14:09 bradmartin

+1

lukeramsden avatar Dec 15 '16 12:12 lukeramsden

Is there any news on this? If not, is there something that I can do to help?

jbfulgencio avatar Jan 14 '17 11:01 jbfulgencio

I haven't had any time lately to work on it. Making it work with the video player is a lot of work. A good alternative might be to have a separate plugin using one of the popular third party android video libs that has done the work of Fullscreen on all the different android APIs. It might be faster to take that approach. However having this plugin support it would still be great I just haven't had time to work on it. Sorry.

bradmartin avatar Jan 14 '17 14:01 bradmartin

Hey @jbfulgencio in our implementation of the plugin, we actually do this manually by making the video itself 100% height and width. You could even animate that.

bnussey avatar Jan 14 '17 19:01 bnussey

I haven't played with the plugin since the major update. That's awesome @bnussey

On Sat, Jan 14, 2017, 1:20 PM bnussey [email protected] wrote:

Hey @jbfulgencio https://github.com/jbfulgencio in our implementation of the plugin, we actually do this manually by making the video itself 100% height and width. You could even animate that.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/bradmartin/nativescript-videoplayer/issues/14#issuecomment-272646481, or mute the thread https://github.com/notifications/unsubscribe-auth/AFulhPZJUF9foaS_LjqftNkm1uZO6hgUks5rSR_qgaJpZM4H9vS2 .

bradmartin avatar Jan 14 '17 20:01 bradmartin

Yeah I was also looking at Google's Exoplayer and we've been thinking of using that instead of MediaPlayer. Looks like a more advanced API and greater functionality. Will keep you all posted.

bnussey avatar Jan 14 '17 21:01 bnussey

@bnussey any updates to that?

lukeramsden avatar Mar 13 '17 15:03 lukeramsden

@bradmartin Is there a function to call to be able to trigger the same fullscreen mode that is triggered when the controls are shown? I looked through all links posted but they are all referring to android.

christian-kolb avatar Sep 19 '17 21:09 christian-kolb

+1 any news? Would love to have videos in fullscreen :)

sfaessler avatar Sep 22 '17 22:09 sfaessler

+1 , people really like to see a video in full screen :)

c1ngular avatar Sep 25 '17 08:09 c1ngular

I have no time to work on this right now. If anyone wants to work on it to get a PR going and needs guidance I can chat from time to time but I'm too busy to put in the work to get the functionality working smoothly. If you absolutely need the fullscreen option in your NS app right now, the exoplayer plugin is a perfect solution.

bradmartin avatar Sep 25 '17 14:09 bradmartin

Similar to @bnussey, I'm currently working on a fullscreen ability and basically open a nativescript angular modal window with a new video player in it. so far looks great (checked only on android emulator) Using Screen Orientation plugin to switch back a forth if required and the modal window automatically closes when back button pressed calls a callback function.

P.S if using this solution don't forget to 'freeze' the embedded player when opening the full screen one as you don't want it to keep using bandwidth in the background

souly1 avatar Sep 25 '17 15:09 souly1

+1

fransyozef avatar Sep 07 '18 09:09 fransyozef

I want it too. Any news ?

cloudSchulze avatar Oct 27 '18 10:10 cloudSchulze