nativescript-camera-plus icon indicating copy to clipboard operation
nativescript-camera-plus copied to clipboard
verified publisher icon nstudio

DON'T MERGE: Fixed camera not opening from modal on iOS

Open surdu opened this issue 7 years ago • 6 comments

Fixes #15 & #30

surdu avatar Sep 17 '18 13:09 surdu

There is still an issue here of not being able to select a picture anymore from a modal. A temporary fix for now for us is to comment this line.

We'll try to find a proper solution soon ...

surdu avatar Sep 17 '18 13:09 surdu

@surdu - still not ready to merge correct?

bradmartin avatar Sep 19 '18 03:09 bradmartin

@bradmartin correct 😞

surdu avatar Sep 19 '18 07:09 surdu

Hmm... It appears the problem was on our code, because we where not showing the modal the "correct" way, using the new approach with the frame.

That being said, please still don't merge this yet as I want to add a button in the demo app to showcase the modal behaviour (and/or update the docs).

surdu avatar Oct 23 '18 15:10 surdu

@surdu Did you finally find a solution for #15 and #30 ?

Thanks a lot,

nickykln avatar Apr 22 '19 06:04 nickykln

@nickykln If I remember correctly, this fixed the problem. I just have to remember specifically what was still needed for this PR (it was some time since I didn't used this) and should be good to merge

surdu avatar Apr 22 '19 07:04 surdu