Nicolas Stepien

Results 111 comments of Nicolas Stepien

Would be nice to have in win10 as well. https://docs.microsoft.com/en-us/windows/uwp/design/style/acrylic

https://github.com/testing-library/react-testing-library/blob/9171163fccf0a7ea43763475ca2980898b4079a5/src/pure.js#L19-L24 It looks like this is the culprit, it disables the "act environment" while running `waitFor`. This doesn't make sense to me, any particular reason for doing this @eps1lon?

>Anything wrapped in `act` will only flush updates when we exit its scope. Is this documented somewhere? >if we would wait asynchronously for 5s which is wrapped in `act` then...

I have a test roughly like this: ```ts setup(); await userEvent.click(someButton); await waitFor(() => expect(getCell()).toHaveTextContent('...'); ); ``` Clicking the button triggers an function with an API call roughly like this:...

So even something like `obj.data === undefined` would trigger suspense? We'd have to be very careful in cases where we don't want to suspend the page while it's fetching, IMO...

Ah I didn't notice that `suspense: true` is still needed (it's missing in the opening comment). I think I'd still prefer `.read()`: - the `suspense` setting wouldn't be needed anymore...

Would it help if iltorb offered pre-built binary fallbacks? I don't know how to go about that however.

https://twitter.com/rvagg/status/748114279685988352 This could help in the future.

iltorb now offers pre-built binaries, and features a `.flush()` method for compression streams.