nsq icon indicating copy to clipboard operation
nsq copied to clipboard

nsqadmin: add option to skip resolving on startup

Open martin-sucha opened this issue 3 years ago • 2 comments

When running nsqlookupd in Kubernetes and pointing to a specific identity of a pod from statefulset, the DNS name is not resolvable if the pod is not currently scheduled.

The lookup check currently causes nsqadmin to exit during startup even if only one of the listed nsqlookupd instances is not resolvable.

I want nsqadmin to always start. If no lookupd instances are currently resolvable/reachable that fact will be visible in the user interface.

martin-sucha avatar Mar 17 '21 14:03 martin-sucha

ready for review

martin-sucha avatar Mar 17 '21 14:03 martin-sucha

Hey @martin-sucha thanks for the PR.

This code path ultimately just validates that we have a proper hostname or IP address - I agree that the resolution of the hostname is probably not something we need to fatally exit on.

So, I don't think the answer here is a new command line flag, but rather validation of the format and not the name resolution.

mreiferson avatar Mar 21 '21 23:03 mreiferson