[Android] Enable LTO

[Vogtinator]

On armeabi-v7a it's broken in two ways. Also simplify the LTCG determination code and print the result.

Depends on #285

[Vogtinator]

@adriweb Looks like the case without HAVE_SECRETS isn't working

[adriweb]

@adriweb Looks like the case without HAVE_SECRETS isn't working

Indeed... How does that not work, though? We see HAVE_SECRETS: false in the env dump, and it has an if ${{ env.HAVE_SECRETS == 'true' }} ...

[Vogtinator]

@adriweb Looks like the case without HAVE_SECRETS isn't working

Indeed... How does that not work, though? We see HAVE_SECRETS: false in the env dump, and it has an if ${{ env.HAVE_SECRETS == 'true' }} ...

Maybe just if: runner.os == 'macOS' && github.repository == 'nspire-emus/firebird' && env.HAVE_SECRETS == 'true' ?

[adriweb]

I'll try, but the original version was a copy paste from some big repo CI that seemingly worked heh

[Vogtinator]

Apparently secrets are not available in if, maybe env isn't available either? https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-secrets

[adriweb]

well apparently it's because secrets aren't available in if that the intermediate "putting the boolean value in env" step is required for the check, but...

[Vogtinator]

My assumption would be that env is computed only when a step is run, but if has to be computed much earlier than that to determine whether to run the step at all.

[adriweb]

My assumption would be that env is computed only when a step is run, but if has to be computed much earlier than that to determine whether to run the step at all.

Well the docs about that say it should be fine: "You can use a context in an if conditional statement to access the value of an environment variable." And the syntax i their example is if: ${{ env.DAY_OF_WEEK == 'Monday' }} which is what I also do: if: ... && ${{ env.HAVE_SECRETS == 'true' }}

So... wut ?

Edit: maybe it's a syntax thing and ${{ .. }} should wrap the whole expression ; I'll try that

[Vogtinator]

Edit: maybe it's a syntax thing and ${{ .. }} should wrap the whole expression ; I'll try that

That was my first guess as well, the if is implicitly wrapped in ${{}} already and nesting that might not work.

[adriweb]

I'll let you rebase and see if it works now 🤷‍♂️