firebird icon indicating copy to clipboard operation
firebird copied to clipboard

New flash creation dialog in QML

Open Vogtinator opened this issue 2 years ago • 13 comments

New flash creation dialog + an Android usability improvement + QML fixes.

With this, the warnings on exit are finally gone!

Android Linux (Plasma Wayland)
Screenshot_20220417_202742

@adriweb Please test whether the dialog works as expected on macOS and especially iOS as well.

Vogtinator avatar Apr 17 '22 18:04 Vogtinator

on macOS, I guess it's OK? (ignore the type discrepancy, I just chose the first file I came across) image

I'll try to test on iOS sometime soon.

adriweb avatar Apr 17 '22 20:04 adriweb

That said, the two list selects seem to be read-only somehow: image

adriweb avatar Apr 17 '22 20:04 adriweb

Do they only look read-only or are they actually read-only? Might just be a weird color scheme

Vogtinator avatar Apr 18 '22 10:04 Vogtinator

They're actually read only. Is there any condition that makes them this way?

adriweb avatar Apr 18 '22 10:04 adriweb

No, that makes no sense... https://doc.qt.io/qt-5/qml-qtquick-controls-combobox.html doesn't even have an enabled property!

Do other comboboxes in the config dialog behave similarly?

Vogtinator avatar Apr 18 '22 11:04 Vogtinator

Do other comboboxes in the config dialog behave similarly?

Everything else behaves correctly

adriweb avatar Apr 18 '22 20:04 adriweb

Can you add this in strategic places to find what disables it?

Component.onCompleted: console.log("Enabled", enabled)    
onEnabledChanged: console.log("Enabled changed", enabled)

Vogtinator avatar Apr 29 '22 16:04 Vogtinator

Well, I tried, and it prints this:

qml: subtypeCombo Enabled true
qml: modelCombo Enabled true

Seems like a Qt bug on macOS then, who knows....

That said, even if the UI is messed up, tabbing to the control to get its focus, then pressing the arrow keys to select the wanted option, works fine (as long as you don't open the dropdown)

adriweb avatar Aug 04 '22 09:08 adriweb

OK it is a Qt Bug, but not fixed in OSS releases ... https://bugreports.qt.io/browse/QTBUG-89607 / https://forum.qt.io/topic/123101/quick-controls-1-combobox-items-unselectable-on-macos/9

adriweb avatar Aug 04 '22 09:08 adriweb

OK it is a Qt Bug, but not fixed in OSS releases ... https://bugreports.qt.io/browse/QTBUG-89607 / https://forum.qt.io/topic/123101/quick-controls-1-combobox-items-unselectable-on-macos/9

According to that, the issue is fixed in 5.15.3. Can you try the latest 5.15.5?

Vogtinator avatar Aug 04 '22 09:08 Vogtinator

According to that, the issue is fixed in 5.15.3. Can you try the latest 5.15.5?

Well 5.15.5 doesn't seem to be available - it stops at 5.15.2 here... 🤔

adriweb avatar Aug 04 '22 10:08 adriweb

According to that, the issue is fixed in 5.15.3. Can you try the latest 5.15.5?

Well 5.15.5 doesn't seem to be available - it stops at 5.15.2 here... thinking

Maybe they just do (pathetic) delayed source releleases but no binary ones? Annoying...

Vogtinator avatar Aug 04 '22 10:08 Vogtinator

Might be time to upgrade to Qt6 :P

adriweb avatar Aug 04 '22 10:08 adriweb

I added a workaround for the Qt bug, can you try whether that works?

Vogtinator avatar Oct 20 '22 08:10 Vogtinator

Some usual Qt weirdness regarding text alignment and focus oddities, but it does work :)

image

adriweb avatar Oct 20 '22 13:10 adriweb

Were you able to test on iOS as well?

Vogtinator avatar Oct 20 '22 14:10 Vogtinator

Ah, no, not yet anyway, just macOS for now.

adriweb avatar Oct 20 '22 14:10 adriweb

tested OK on iOS

adriweb avatar Nov 04 '22 16:11 adriweb