neofs-node
neofs-node copied to clipboard
nspcc-dev
NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
TBD :writing_hand:
* based on #2408 * see @AnnaShaleva https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1252066039 ## Overview according to introduced changes, all committee members do all committee actions (such as updating the NNS contract) on their own...
Some questions: 1. Why does it have [workers](https://github.com/nspcc-dev/neofs-node/blob/5ca26a877c1ad5c21b416a00d292a50bd40964c7/pkg/innerring/innerring.go#L107), [starters](https://github.com/nspcc-dev/neofs-node/blob/5ca26a877c1ad5c21b416a00d292a50bd40964c7/pkg/innerring/innerring.go#L115) and [runners](https://github.com/nspcc-dev/neofs-node/blob/5ca26a877c1ad5c21b416a00d292a50bd40964c7/pkg/innerring/innerring.go#L129C3-L129C10)? Also, all of them are anonymous, it makes it difficult to understand what "services" (well, just `func ()`) are...
* raised in go1.20 tests #2408 ``` --- FAIL: TestEvacuateNetwork (0.18s) --- FAIL: TestEvacuateNetwork/multiple_shards,_evacuate_many (0.08s) logger.go:130: [202](https://github.com/nspcc-dev/neofs-node/actions/runs/5393697086/jobs/9793798286?pr=2408#step:4:203)3-06-27T19:13:17.072Z DEBUG opening... {"shard_id": "B44bWVTm19CTXG3FsRVdgX"} logger.go:130: 2023-06-27T19:13:17.072Z DEBUG opening... {"shard_id": "X8LvzFKsWtpCT9XxvoAY7M"} logger.go:130: 2023-06-27T19:13:17.072Z DEBUG...
I would add some: - ~~containedctx: [thoughts](https://github.com/nspcc-dev/neo-go/issues/3026#issuecomment-1569124458)~~ (see https://github.com/nspcc-dev/neofs-node/issues/1911) - ~~contextcheck: will help the linter above, it encourages passing `context.Context`~~ (see https://github.com/nspcc-dev/neofs-node/issues/1911) - funlen: [thoughts](https://github.com/nspcc-dev/neofs-node/pull/2402#discussion_r1242949612) - gocognit: I see too...
It has hard coded [hashes](https://github.com/nspcc-dev/neofs-node/blob/fc8dd84fae4979c21c1f3275134a37204a2d10c2/cmd/neofs-adm/internal/modules/storagecfg/config.go#L82-L85) and [RPCs](https://github.com/nspcc-dev/neofs-node/blob/fc8dd84fae4979c21c1f3275134a37204a2d10c2/cmd/neofs-adm/internal/modules/storagecfg/config.go#L96-L133). Testnet does not work. Not found for a long time => not used for a long time.
What I have read: - https://github.com/nspcc-dev/neofs-node/pull/170 - https://docs.neo.org/docs/en-us/basic/governance.html - https://github.com/nspcc-dev/neofs-node/issues/2311 - https://github.com/nspcc-dev/neofs-node/pull/2363 The question: why do we need it? What is the purpose of such voting? Why can't it be...
After https://github.com/nspcc-dev/neofs-node/pull/2135 a user can see the following (15-sec default timeout that did not exist before): ```bash ▶ neofs-cli object put -r s01.neofs.devenv:8080 -w services/chain/node-wallet.json --cid HrG4qXKc3fpvY1dBay4Jy4qtDgGbwEnDtikDUJTegZJi --file tmp/test.file Enter...
> So my point is: if it is possible to warn a user that some calls are useless by design, I would do it. About the rest, I am ok....
## Expected Behavior We should have some up to date documents in `docs` and examples in `config`. ## Current Behavior READMEs are obviously outdated and located in wrong place (see...