neo-go icon indicating copy to clipboard operation
neo-go copied to clipboard

core: restrict the number of allowed SC notifications

Open AnnaShaleva opened this issue 1 year ago • 1 comments

Close #3490.

@roman-khimov, what do you think? Another option is to cache size for every emitted notification and then check the overall notifications size every time we're going to emit one more notification, it also may be implemented.

I'll add more tests once we agree on solution.

AnnaShaleva avatar Oct 23 '24 12:10 AnnaShaleva

Ref. https://github.com/neo-project/neo/pull/3548.

AnnaShaleva avatar Oct 23 '24 16:10 AnnaShaleva

Codecov Report

Attention: Patch coverage is 38.09524% with 39 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (e63cbe7) to head (2c8bd05). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/core/native/native_neo.go 25.00% 12 Missing and 6 partials :warning:
pkg/core/native/management.go 40.00% 5 Missing and 4 partials :warning:
pkg/core/native/oracle.go 25.00% 4 Missing and 2 partials :warning:
pkg/core/interop/context.go 62.50% 2 Missing and 1 partial :warning:
pkg/core/native/native_nep17.go 50.00% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3640      +/-   ##
==========================================
- Coverage   82.88%   82.74%   -0.14%     
==========================================
  Files         338      338              
  Lines       47448    47484      +36     
==========================================
- Hits        39326    39290      -36     
- Misses       6502     6563      +61     
- Partials     1620     1631      +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 06 '25 14:03 codecov[bot]