neo-go icon indicating copy to clipboard operation
neo-go copied to clipboard

cli: allow dynamic contract hash for contract bindings

Open AliceInHunterland opened this issue 1 year ago • 2 comments

Close #3007

AliceInHunterland avatar Apr 08 '24 12:04 AliceInHunterland

I would like to ensure that generated wrapper with dynamic hash is valid. Can we create a test (using neotest): generate wrapper with dynamic hash for some test contract (we may reuse one of the already existing test contracts), create a tiny helper contract that uses this wrapper inside some simple API (that creates an instance of Contract and calls its method):

func CallWrapper(h interop.Hash160) int {
    ...
}

Then deploy both contract and helper, then call helper and check that everything works as expected.

AnnaShaleva avatar Apr 09 '24 09:04 AnnaShaleva

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.09%. Comparing base (8913542) to head (c5dbecb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3405      +/-   ##
==========================================
+ Coverage   86.08%   86.09%   +0.01%     
==========================================
  Files         331      331              
  Lines       38107    38106       -1     
==========================================
+ Hits        32805    32808       +3     
+ Misses       3785     3782       -3     
+ Partials     1517     1516       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 10 '24 13:04 codecov[bot]