neo-go
neo-go copied to clipboard
peer disconnected not a warn
steps to reproduce: start neogo from the command line and stop it with ctrl-c:
^C2023-10-31T20:11:54.815+0300 INFO shutting down server {"peers": 11}
2023-10-31T20:11:54.815+0300 WARN peer disconnected {"addr": "170.64.152.72:51333", "error": "server shutdown", "peerCount": 10}
2023-10-31T20:11:54.815+0300 WARN peer disconnected {"addr": "65.108.90.74:51333", "error": "server shutdown", "peerCount": 9}
2023-10-31T20:11:54.815+0300 WARN peer disconnected {"addr": "159.203.28.78:51333", "error": "server shutdown", "peerCount": 8}
2023-10-31T20:11:54.815+0300 WARN peer disconnected {"addr": "49.12.226.190:50333", "error": "server shutdown", "peerCount": 7}
2023-10-31T20:11:54.815+0300 WARN peer disconnected {"addr": "5.78.81.79:51333", "error": "server shutdown", "peerCount": 6}
2023-10-31T20:11:54.815+0300 WARN peer disconnected {"addr": "49.12.226.190:51333", "error": "server shutdown", "peerCount": 5}
2023-10-31T20:11:54.815+0300 WARN peer disconnected {"addr": "170.64.152.72:50333", "error": "server shutdown", "peerCount": 4}
2023-10-31T20:11:54.815+0300 WARN peer disconnected {"addr": "116.203.249.217:50333", "error": "server shutdown", "peerCount": 3}
2023-10-31T20:11:54.815+0300 WARN peer disconnected {"addr": "167.71.212.120:50333", "error": "server shutdown", "peerCount": 2}
2023-10-31T20:11:54.815+0300 WARN peer disconnected {"addr": "159.203.28.78:50333", "error": "server shutdown", "peerCount": 1}
2023-10-31T20:11:54.815+0300 WARN peer disconnected {"addr": "65.108.90.74:50333", "error": "server shutdown", "peerCount": 0}
2023-10-31T20:11:55.201+0300 INFO persisted to disk {"blocks": 1367, "keys": 22958, "headerHeight": 353191, "blockHeight": 353191, "took": "385.464896ms"}
peer disconnected is not a warning!
Peer disconnection may happen due to a various set of reasons and sometimes it may be a WARN. What we may do wrt this logic is try to split WARN/INFO cases.
in what case, for example, it is a warn?
I need to check the code, we have a various set of peer disconnection reasons. Will be done when the task is taken to work.
I believe all reasons of peer disconnections are not warnings. Do you have a counterexample?