neo-go icon indicating copy to clipboard operation
neo-go copied to clipboard

examples: port changes from C# NNS contract

Open AnnaShaleva opened this issue 3 years ago • 1 comments

This PR includes changes implemented into C# NNS version (https://github.com/neo-project/non-native-contracts/blob/master/src/NameService/NameService.cs):

  1. Domain registration price is dependant on domain name length. By default, short (<5 chars) domain names are available for registration only for committee.
  2. Renew overload is added that accepts expiration period as an argument. This change is backwords-compatible.
  3. SetAdmin and Renew events are added.

AnnaShaleva avatar Sep 16 '22 08:09 AnnaShaleva

Codecov Report

Merging #2694 (abd332f) into master (20224cb) will increase coverage by 0.27%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2694      +/-   ##
==========================================
+ Coverage   85.23%   85.50%   +0.27%     
==========================================
  Files         322      322              
  Lines       39398    39680     +282     
==========================================
+ Hits        33580    33928     +348     
+ Misses       4479     4423      -56     
+ Partials     1339     1329      -10     
Impacted Files Coverage Δ
pkg/network/message.go 94.02% <0.00%> (-1.50%) :arrow_down:
pkg/services/notary/notary.go 82.08% <0.00%> (-0.55%) :arrow_down:
pkg/services/stateroot/network.go 76.71% <0.00%> (-0.32%) :arrow_down:
pkg/services/oracle/response.go 84.80% <0.00%> (-0.24%) :arrow_down:
pkg/network/server.go 73.08% <0.00%> (-0.17%) :arrow_down:
pkg/neorpc/errors.go 69.69% <0.00%> (ø)
pkg/rpcclient/nep11.go 0.00% <0.00%> (ø)
pkg/consensus/crypto.go 100.00% <0.00%> (ø)
pkg/rpcclient/policy.go 65.38% <0.00%> (ø)
pkg/util/slice/array.go 100.00% <0.00%> (ø)
... and 45 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 16 '22 08:09 codecov[bot]