neo-go icon indicating copy to clipboard operation
neo-go copied to clipboard

Emit compiler warning/error if a permission specifies unused method

Open fyrchik opened this issue 2 years ago • 1 comments

See https://github.com/nspcc-dev/neofs-contract/pull/265 We can do this if all callsites have constant method names. This should cover 99% of our cases.

Depending on the implementation of https://github.com/neo-project/neo/pull/2756, these warnings could become even more important.

fyrchik avatar Sep 07 '22 09:09 fyrchik

Not sure about this one. When we see a call with clear hash/method combination and can't find a matching permission it's 100% accurate easily detectable error, but it's not the same the other way around. If "all callsites have constant method names" maybe, but even then we have */method permissions that can be too broad in some scenarios.

roman-khimov avatar Sep 09 '22 10:09 roman-khimov