Swiftline icon indicating copy to clipboard operation
Swiftline copied to clipboard

Fix: properly convert `NSString?` to `String?`

Open tconkling opened this issue 7 years ago • 2 comments

This fixes the following warning:

RunResults.swift:39:82: Conditional downcast from 'NSString?' to 'String' is a bridging conversion; did you mean to use 'as'?

tconkling avatar May 24 '17 23:05 tconkling

Codecov Report

Merging #34 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files          39       39           
  Lines        1543     1543           
=======================================
  Hits         1497     1497           
  Misses         46       46
Impacted Files Coverage Δ
Source/RunResults.swift 87.5% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f84dee...c4223d0. Read the comment docs.

codecov-io avatar May 24 '17 23:05 codecov-io

I bet if this gets pulled into master, Swiftline will reach 1000 stars on github!!

🌟🌟🌟🌟🌟🌟🌟🌟🌟🌟 * 100

klaas avatar Jun 03 '17 09:06 klaas